Jump to content

Quick Search Template

Closed 2.0.2 Next Version

When replacing the ipsNavBar_primary menu, the search box is missing.

Would it be possible to have this element within the Primaray menu like it is with the Default template.

I had to add:

{template="quickSearch" group="global" app="core" params="$preview"}

To:

    <nav id="{$data->group->key}_{$data->group->loc}_nav" class="cjmg_nav ipsClearfix{{if settings.cjmg_remove_primary && $data->group->loc == 'primary'}} cjmg_primary_z{{endif}}{{if $widget === true}} cjmg_widget{{endif}}"{{if !$data->group->type  && $data->group->bits['bw_no_more'] === false}} data-ipscjmore{{endif}}>
        <ul id="{$data->group->key}_menu" class="ipsClearfix {{if !$data->group->type}}cjmg_bar{{else}}cjmg_block_nav{{endif}} {{if settings.cjmg_remove_primary && $data->group->loc == 'primary'}}cjmg_primary_z{{endif}}" data-ipscjmgm data-ipscjmgm-settings="{$data->group->settings}" data-ipscjmgm-bd data-ipscjmgm-url data-ipscjmgm-app>
            {{if isset($data->parsed[0])}}
                {{foreach $data->parsed[0] as $key => $item}}
                    {template="item" group="menus" location="front" app="cjmg" params="$item,$data"}
                {{endforeach}}
                {{if !$data->group->type && $data->group->bits['bw_no_more'] === false}}
                <li id="cjmg_more" class="ipsClearfix cjmg_parent_item cjmg_anchor ipsHide" data-role="navItem">
                    <a href="#" id="elNavigation_app_more" class="{{if $data->group->behavior === 1}}cjmg_click{{else}}cjmg_hover{{endif}}">
                        <span>{lang='cjmg_menus_item_more'}</span>
                        {{if $data->group->behavior === 2}}
                        <i class="cjmg_arrow cjmg_arrow_hover fa fa-angle-down pull-right"></i>
                        {{endif}}
                    </a>
                    {{if $data->group->behavior === 1}}
                    <i class="cjmg_arrow cjmg_arrow_click fa fa-angle-down pull-right"></i>
                    {{endif}}
                    <div class="cjmg_mega cjmg_child_container ipsClearfix cjmg_shadow" style="z-index: {$data->group->zindex}">
                        <ul class="cjmg_child_items ipsClearFix">
                        </ul>
                    </div>
                </li>
                {{endif}}
            {{endif}}
        </ul>
      {template="quickSearch" group="global" app="core" params="$preview"} /*added*/
    </nav>

With the following css to the custom css styles:

#ipsLayout_header .cjmg > nav {
    display: flex;
    align-items: center;
    justify-content: space-between;
    position: relative;
}

 

Share this comment


Link to comment

2020-10-02_10-10.png

on the default theme, the search appears above the menu like this. 

on custom themes, there might need to be some tweaking, as mgm tries its best to remove the ips menu with trying to keep the the elements intact (like search). but on custom themes, that structure might be different and MGM will fail to remove it properly or at all. 

Share this comment


Link to comment
49 minutes ago, Michael said:

Changed Status from Pending to Not a Bug

I think you need to recheck check your default template or remove your menu application as it is giving you the wrong impression.

The default search looks like this: (Hence the reason why I posted these issues.)

344907370_Screenshot_2020-10-02ATestForum.thumb.png.c67881f722315a8ad2fa82a247592523.png

Edited by TDBF

Share this comment


Link to comment
26 minutes ago, TDBF said:

I think you need to recheck check your default template or remove your menu application as it is giving you the wrong impression.

The default search looks like this: (Hence the reason why I posted these issues.)

344907370_Screenshot_2020-10-02ATestForum.thumb.png.c67881f722315a8ad2fa82a247592523.png

And this the theme after I activate your application.

654592722_Screenshot_2020-10-02ATestForum(1).thumb.png.d446ddfecf081db39111b56ff41833cd.png

Share this comment


Link to comment
14 minutes ago, TDBF said:

The default search looks like this: (Hence the reason why I posted these issues.)

 

I use to do it this way back in the early days of cj menu, but changed it cause of the variety of differences that can occur with custom themes (and including the number of complaints i would get about it that way). 

version 1.0 of cj menu use to replace that area all together and do as you suggested to add in the search to the menu bar, but then ips 4.1 came along and the search and menu were no longer contained together like they were in 4.0 (as the menu is pulled upwards via css so they appear on the same line). when i adapted cj menu for 4.1, i got a ton of complaints about "duplicate search" boxes, cause the solution was to do it the way i had done in 4.1, and replace the not only the actual menu and search with one from cj menu, but theme designers for 4.1+ now had the ability to move the search to other sections of the site, vs having it statically bound to the menu. 

there is also the problem with injecting mgm directly into that area too, starting with 4.1, since they added in the "sub menu" they also added a ton of css to handle that, that isn't easily overridden and conflicts with the structure that cj menu/MGM has, so my only option was to move it below that area. 

so all in all, there are reasons i did it this way, they might not make entire sense at first, but they do on a development perspective and trying to meet the demands of all clients that use mgm. out of the last 4 or so years its been like this, this is the first complaint on it, but compared to the way it was, where i was getting 5 to 10 complaints a week with the way cj menu use to do it, i'll take the once off complaint :)

so i understand it can be frustrating, or even annoying, but i'm replacing their highly customized menu, with a highly customized menu, so some exceptions had to be made.

Share this comment


Link to comment
13 minutes ago, TDBF said:

And this the theme after I activate your application.

654592722_Screenshot_2020-10-02ATestForum(1).thumb.png.d446ddfecf081db39111b56ff41833cd.png

yes, with mgm, the search appears above the menu, its done by design, as i explained in the post before. 

Share this comment


Link to comment
1 hour ago, Michael said:

on the default theme, the search appears above the menu like this. 

I'm sorry mate, but you seemed to have changed on this, firstly it was because this is the way it is done by IPS and now it is because you choose to do it this way? :)

Personally, if I where doing this and I was replacing the default menu, then I would have made it look as it was as the default out of the box and let the theme merchants worry about their own code later. (To me, the way you do it looks bugged right out the box and I would expect a like for like look as the customer).

Fine, if that is the way you want to do this, I will just have to modify the code on each update (which is a pain in that arse) and I will just have accept that this is they way you want it.

As the way is stands, Installing and activating this module kills my Menu straight away without adding any CMJ Menus (See image below). 

Firstly, you have injected your own primaryNavBar code (No check to see that there is a menu) and this moved the original menu content to the right.

Secondly, you have used the wrong colour for the Navigation .

#ipsLayout_header nav:not(.cjmg_nav){
    position:unset;
    background:rgb( var(--theme-header) );
}

It should have been this:

#ipsLayout_header nav:not(.cjmg_nav){
    position:unset;
    background:rgb( var(--theme-main_nav) );
}

Sorry, I am not trying to be pedantic over these matters, but,straight out the box the IPS menu gets bugged straight away and that means I cannot activate your application and create menus.

I just think that this is a fantastic application which I have tried to use 4 times (Since I originally bought it) and finally gave up due to the issues, bug and general annoyances with the front part of the side, mainly the css and templates).

I hope you don't take my posts the wrong way, as they are intended as to help with bugs and issues. :)

Kind Regards,

John

Installbugs.thumb.jpg.3852c416b4c3ccf1848c77fc62819acb.jpg

Share this comment


Link to comment
1 minute ago, TDBF said:

I'm sorry mate, but you seemed to have changed on this, firstly it was because this is the way it is done by IPS and now it is because you choose to do it this way? :)

 

i had always meant that it was the way mgm works on the default theme, not how IPS does it. in the screen shot i shared, that is MGM running on the default theme on my dev environment, i just didn't say "this is how mgm does it" like i did later. 

2 minutes ago, TDBF said:

Personally, if I where doing this and I was replacing the default menu, then I would have made it look as it was as the default out of the box and let the theme merchants worry about their own code later. (To me, the way you do it looks bugged right out the box and I would expect a like for like look as the customer).

 

then you never really dealt with IPS "theme merchants", a vast majority of them don't take any accountability with the problems their themes introduce (like removing hook points, having broken tags closing tags that don't present themselves till you hook into it, etc).  so tbh, the design for mgm (as it was in cj menu) was to reduce the number of conflicts. i do mention in the description that the styling for mgm is kept at a minimal to allow easier customization into themes (as i don't want my css to pollute IPS css and vice versa).

like i mentioned, out of the last 4 years its has been like this, and it seems to have accomplished its intended behavior, to give as much compatibility as i can ensure on the default and customs theme. in theory, you could use the same css trick that IPS uses to pull up their menu to be inline with the search. 

34 minutes ago, TDBF said:

Firstly, you have injected your own primaryNavBar code (No check to see that there is a menu) and this moved the original menu content to the right.

 

there are checks, you have to place the menu when you select its group when you first create the group, and then there are an option to attempt to remove the primary. MGM focus is the groups, not so much out of the box replacement for the primary menu like CJ Menu was. so if you have a menu there you want to preserve, you can use one of the menu locations or create a hook for it. 

36 minutes ago, TDBF said:

Secondly, you have used the wrong colour for the Navigation .


 

this is intentional, cause mgm for primary location places the menu below the primary, otherwise it looks like this and that is not the look i wanted for mgm:

2020-10-02_12-43.png

39 minutes ago, TDBF said:

Sorry, I am not trying to be pedantic over these matters, but,straight out the box the IPS menu gets bugged straight away and that means I cannot activate your application and create menus.

 

i don't believe it is "bugged" out of the box, it introduces its own style, outside of the IPS menu one, that leaves a lot open so you can style it how you need it to be.  seems the problem is expectations vs reality, as mgm it isn't entirely to be a drop in replacement to the IPS menu like promenu and cj menu was, its meant to give you the ability to create additional menus in more locations outside of the primary location ( it is why i don't guarantee that it can replace the primary menu on all themes, as the primary location can be utilized for a menu underneath the primary too).  Like here on my site, I only use the "mobile" menu on both the desktop and mobile site, as i think it offers a cleaner look than having the bar menu, but that is just one possibility of mgm. 

45 minutes ago, TDBF said:

I hope you don't take my posts the wrong way, as they are intended as to help with bugs and issues. :)

 

if they are bugs, i don't mind fixing them, but i think the main difference here is how we view what MGM actually is. I view it as a way to introduce multiple menus in different views and greater flexibility what those menu's can contain.

2020-10-02_12-51.png

like here, the two groups in the red box are 2 different menu groups used in the widget, and the bottom section is a menu group placed in the footer location, using the block type and a magic menu to generate a custom footer menu based on user logged in status and their group they are on. so there is a ton of powerful features in mgm that i don't think you have yet explored to see what it can do :) or what it can be used for. 

regards,

Michael

Share this comment


Link to comment
31 minutes ago, Michael said:

then you never really dealt with IPS "theme merchants", a vast majority of them don't take any accountability with the problems their themes introduce (like removing hook points,

No, but trust me I have dealt with much worse over my last 30 years in development 😂

Thank you for the explanation, I personally disagree with you (as a developer myself), but as you are the developer of the software I will respect your decisions, and as I previously pointed out, I will make modifications to the templates and CSS now that I know what is what. :)

However, This is a bug:

This is what happens when your application is first installed and there are no 'MGM' menu's or the "Remove Primary" option disabled. If I install this application on my live site, then no one can read the default IPS menu items. This is why this 'feature' makes it unworkable for me out the box.

As you can see, my main menu are obfuscated (Yes the IPS Menu items are there) due to the issues I outline in my last post. I have NOT created a MGM menu for the primary Menu, nor have I removed it via the Remove Primary option and under these conditions, the IPS menu should be untouched. Hence why I suggested that this be treated as a bug. Sorry! :)

 Installbugs.thumb.jpg.0a6faf4be4f61a1d72d7f8a866c9fc43.jpg

Edited by TDBF

Share this comment


Link to comment
1 hour ago, TDBF said:

As you can see, my main menu are obfuscated (Yes the IPS Menu items are there) due to the issues I outline in my last post. I have NOT created a MGM menu for the primary Menu, nor have I removed it via the Remove Primary option and under these conditions, the IPS menu should be untouched. Hence why I suggested that this be treated as a bug. Sorry! :)

 

i've identified the issue and fixed it for the next version.

1 hour ago, TDBF said:

Thank you for the explanation, I personally disagree with you (as a developer myself), but as you are the developer of the software I will respect your decisions, and as I previously pointed out, I will make modifications to the templates and CSS now that I know what is what. :)

 

well then you know that is a balance between what clients want/need and what you want and need :) as i do use mgm myself on several of my sites, and this solution has worked 95% of the time for those needs too. I don't mind making changes if there are demands, but there is always a trade off :) . 

Share this comment


Link to comment
3 minutes ago, Michael said:

i've identified the issue and fixed it for the next version.

well then you know that is a balance between what clients want/need and what you want and need :) as i do use mgm myself on several of my sites, and this solution has worked 95% of the time for those needs too. I don't mind making changes if there are demands, but there is always a trade off :) . 

Hi Michael,

Much appreciated and thank you for your time on this matter. :)

Oh most definitely, I have worked for some of the most demanding employers, clients and open source people you can meet, so I do understand the difference between needs and wants.  However, I do understand that sometimes we developers are reluctant to change and sometimes we don't see what others do because we are too deep in the code.

As I said before, I only put these forward because I believed they could be issues or bugs which required attention and could be addressed. I won't take it personal if you don't see it that way either :). I could have just fixed the issues myself, but I just wanted to save someone else the time and issues by reporting them to yourself.

Have a good day bud, and thank you again! 👍

Share this comment


Link to comment
×
×
  • Create New...